Skip to content

refactor: move net_protocol::Blobs to top level as BlobsProtocol #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented Jul 11, 2025

Description

also make net_protocol private since it contains nothing else.

Breaking Changes

removed net_protocol module
added crate::BlobsProtocol

Notes & open questions

We could do the reexport in 1 release and then the removal in the next, but I think at this point we don't need to be so strict.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

also make net_protocol private since it contains nothing else.
@rklaehn rklaehn requested a review from Frando July 11, 2025 09:47
Copy link

github-actions bot commented Jul 11, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/112/docs/iroh_blobs/

Last updated: 2025-07-11T09:53:05Z

@n0bot n0bot bot added this to iroh Jul 11, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jul 11, 2025
Copy link
Member

@Frando Frando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rklaehn rklaehn merged commit bc61e8e into main Jul 11, 2025
23 of 24 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jul 11, 2025
@rklaehn rklaehn deleted the blobs-protocol-toplevel branch July 11, 2025 11:54
rklaehn added a commit that referenced this pull request Jul 11, 2025
Was broken by #112
@rklaehn rklaehn mentioned this pull request Jul 11, 2025
4 tasks
rklaehn added a commit that referenced this pull request Jul 11, 2025
Was broken by #112
rklaehn added a commit that referenced this pull request Jul 11, 2025
Was broken by #112
rklaehn added a commit that referenced this pull request Jul 11, 2025
## Description

Was broken by #112

## Breaking Changes

None

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants